Skip to content

fix: Get absoluteUrl from docusaurus context #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 21, 2025
Merged

fix: Get absoluteUrl from docusaurus context #2031

merged 4 commits into from
Oct 21, 2025

Conversation

@HonzaTuron
Copy link
Contributor

@HonzaTuron HonzaTuron commented Oct 21, 2025 •
edited
Loading

Closes #2030

Won't work on staging unfortunately, but managed to run with production build. See comments below.

@HonzaTuron HonzaTuron requested a review from barjin October 21, 2025 13:04
@github-actions github-actions bot added this to the 126th sprint - Web team milestone Oct 21, 2025
@github-actions github-actions bot added the t-web Issues with this label are in the ownership of the web team. label Oct 21, 2025
@HonzaTuron HonzaTuron added the adhoc Ad-hoc unplanned task added during the sprint. label Oct 21, 2025
barjin
barjin reviewed Oct 21, 2025
View reviewed changes
@HonzaTuron HonzaTuron marked this pull request as ready for review October 21, 2025 13:09
@HonzaTuron HonzaTuron requested review from B4nan and barjin October 21, 2025 13:09
@apify-service-account
Copy link

Preview for this PR was built for commit ad0d42d and is ready at https://pr-2031.preview.docs.apify.com!

@apify apify deleted a comment from apify-service-account Oct 21, 2025
@apify apify deleted a comment from apify-service-account Oct 21, 2025
barjin
barjin approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last commit seems to work both during local development (although it's rendering https://localhost:3000/...) and in production build (there it correctly reads the url field from docusaurus.config.js).

wdyt?

@apify-service-account
Copy link

Preview for this PR was built for commit 68e5e5f and is ready at https://pr-2031.preview.docs.apify.com!

B4nan
B4nan approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, i guess lets merge it right ahead, its not just the search that got broken, its basically anything client side, e.g. the "copy for llm" buttons

@HonzaTuron HonzaTuron merged commit 08f4533 into master Oct 21, 2025
9 checks passed
@HonzaTuron HonzaTuron deleted the fix/process-fail branch October 21, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@B4nan B4nan B4nan approved these changes

@barjin barjin barjin approved these changes

Assignees

@HonzaTuron HonzaTuron

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-web Issues with this label are in the ownership of the web team.

Projects

None yet

Milestone

126th sprint - Web team

Development

Successfully merging this pull request may close these issues.

docs-theme - absolute URL method breaks local development

5 participants

@HonzaTuron @apify-service-account @B4nan @barjin