Skip to content

fix: Remove output schema to dataset schema rewrites #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix: Remove output schema to dataset schema rewrites #2050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,10 +533,6 @@ server {
rewrite ^/platform/actors/development/testing-and-maintenance$ /platform/actors/development/deployment/automated-tests redirect;
rewrite ^/platform/actors/development/source-code$ /platform/actors/development/deployment/source-types redirect;

# Rename output schema to dataset schema
rewrite ^/platform/actors/development/actor-definition/output-schema$ /platform/actors/development/actor-definition/dataset-schema permanent;
rewrite ^academy/deploying-your-code/output-schema$ /academy/deploying-your-code/dataset-schema permanent;
Copy link
Member

@valekjo valekjo Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Was this even correct? It's missing the leading / (and so do many other academy links)

Copy link
Member Author

@B4nan B4nan Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most likely not, https://docs.apify.com/academy/deploying-your-code/output-schema is not redirecting anywhere

Copy link
Member Author

@B4nan B4nan Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see only those two that feel wrong:

https://github.com/apify/apify-docs/blob/master/nginx.conf#L536-L538

https://docs.apify.com/academy/advanced-web-scraping/scraping-paginated-sites doesnt redirect

and for some weird reason, https://docs.apify.com/academy/php redirects to GH pages URL (which also ends up as 404)


# Academy restructuring
rewrite ^academy/advanced-web-scraping/scraping-paginated-sites$ /academy/advanced-web-scraping/crawling/crawling-with-search permanent;
rewrite ^academy/php$ /academy/php/use-apify-from-php redirect; # not permanent in case we want to reuse /php in the future
Expand Down