fix: Actor server default tool loading #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the Actor server’s default tool loading by refining URL input parameter parsing and update logic in the GET and POST routes.
- Replaces usage of processParamsGetTools with parseInputParamsFromUrl.
- Adjusts the tool loading conditions in both SSE and POST routes.
- Removes unused helper imports.
Comments suppressed due to low confidence (1)
src/actor/server.ts:71
- The condition checks both 'actors' and 'enableAddingActors', but later default tools are loaded if 'actors' is falsy. Verify that this behavior is intentional, particularly when enableAddingActors is true without actors provided.
if (input.actors || input.enableAddingActors) {
| } | ||
| try { | ||
| log.info(`Received GET message at: ${Routes.ROOT}`); | ||
| // TODO: I think we should remove this logic, root should return only help message |
There was a problem hiding this comment.
[nitpick] If the root route is intended to return only the help message, consider removing this TODO comment and any related legacy logic to improve clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.