fix: optimize dataset items truncation logic #150
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #121
Before we just truncated the stringified dataset JSON, which almost always broke the JSON structure and tool result context (not all fields were present). This new logic pops dataset items one by one from the back either until the max character limit is reached or until only one item is remaining. Then, we improve the truncated info message by guiding the LLM to use the truncated count and offset in the get dataset items tool. This logic keeps the JSON structure valid and ensures that the tool/Actor results fit into the LLM context.
Note: Specific/bad Actors may have weird output schemas and can technically dump the whole output into a single huge dataset item, but I think we should not handle this case - the Actor creator should ensure user and LLM friendly output.