Skip to content

Conversation

@jirispilka
Copy link
Collaborator

@jirispilka jirispilka commented Apr 15, 2025

Add server and example client that support HTTP JSON response

modelcontextprotocol sdk points to a for of the official repo

    "@modelcontextprotocol/sdk": "github:jirispilka/mcp-typescript-sdk#fix/add-src-dir",

TODO: remove file import when the package is published
@jirispilka jirispilka changed the base branch from master to feat/decouple April 15, 2025 11:54
@jirispilka
Copy link
Collaborator Author

@MQ37 Any idea how to fix this?

I've encountered lint issue in CI that I was not able to fix:

/home/runner/work/actors-mcp-server/actors-mcp-server/src/tools/mcp-apify-client.ts
Error:   1:1  error  Too many blank lines at the beginning of file. Max of 0 allowed  no-multiple-empty-lines
✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.
Error: Process completed with exit code 1.

But this is working at my local. I change the workflow to npm run lint:fix to "fix it"

@jirispilka jirispilka marked this pull request as ready for review April 15, 2025 20:24
@jirispilka jirispilka requested review from MQ37 and Copilot April 15, 2025 20:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 22 out of 25 changed files in this pull request and generated 2 comments.

Files not reviewed (3)
  • .nvmrc: Language not supported
  • package.json: Language not supported
  • src/tsconfig.json: Language not supported

@MQ37
Copy link
Contributor

MQ37 commented Apr 15, 2025

@MQ37 Any idea how to fix this?

I've encountered lint issue in CI that I was not able to fix:

/home/runner/work/actors-mcp-server/actors-mcp-server/src/tools/mcp-apify-client.ts
Error:   1:1  error  Too many blank lines at the beginning of file. Max of 0 allowed  no-multiple-empty-lines
✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.
Error: Process completed with exit code 1.

But this is working at my local. I change the workflow to npm run lint:fix to "fix it"

that is weird, also works for me locally - even those previous failing commits 🤷 Let's ignore that for now, I think we should address linter and formatter in the future once all of this is merged and deployed.

Copy link
Contributor

@MQ37 MQ37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably use the express error handler, otherwise good work and LGTM 👍

@jirispilka jirispilka merged commit e918d26 into feat/decouple Apr 16, 2025
1 check passed
@jirispilka jirispilka deleted the feat/http-streamable branch April 16, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants