Skip to content

Conversation

@MQ37
Copy link
Contributor

@MQ37 MQ37 commented Apr 22, 2025

Changes:

  • better error handling and logging

@MQ37 MQ37 requested a review from jirispilka April 22, 2025 14:22
Copy link
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not complicate our lives with caching here.

I think all request are cached at infra level. There is no need to add extra caching here

@MQ37 MQ37 requested a review from jirispilka April 25, 2025 07:17
@MQ37
Copy link
Contributor Author

MQ37 commented Apr 28, 2025

Let's not complicate our lives with caching here.

I think all request are cached at infra level. There is no need to add extra caching here

makes sense, removed the caching stuff 👍

Copy link
Collaborator

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why, this code should span multiple-lines?

                throw new McpError(
                    ErrorCode.InvalidParams,
                    msg,
                );

I think it would fit to one line quite well. The same for other errors, it can be a single line.

@MQ37
Copy link
Contributor Author

MQ37 commented Apr 28, 2025

Is there a reason why, this code should span multiple-lines?

                throw new McpError(
                    ErrorCode.InvalidParams,
                    msg,
                );

I think it would fit to one line quite well. The same for other errors, it can be a single line.

There is no specific reason. I think we should not address formatting/non-functional code style issues. A formatter should handle this once set up.

@MQ37 MQ37 merged commit b43361a into master Apr 28, 2025
2 checks passed
@MQ37 MQ37 deleted the fix/code-improvements branch April 28, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants