Skip to content

Conversation

@MQ37
Copy link
Contributor

@MQ37 MQ37 commented Apr 29, 2025

Closes #98

@github-actions github-actions bot added t-ai Issues owned by the AI team. tested Temporary label used only programatically for some analytics. labels Apr 29, 2025
@MQ37 MQ37 requested a review from Copilot April 29, 2025 07:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements consistent renaming of tool constants to use "actor" terminology instead of "tool."

  • Updated test expectations in tests/actor-server-test.ts for new tool names.
  • Renamed internal tool constants in store_collection.ts, helpers.ts, build.ts, and updated the HelperTools enum in const.ts.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/actor-server-test.ts Updated expected tool names in test assertions.
src/tools/store_collection.ts Renamed SEARCH_ACTOR to SEARCH_ACTORS for internal tool configuration.
src/tools/helpers.ts Renamed ADD_TOOL and REMOVE_TOOL to ADD_ACTOR and REMOVE_ACTOR respectively.
src/tools/build.ts Renamed GET_TOOL_DETAILS to GET_ACTOR_DETAILS; a TODO remains regarding actorFullName.
src/const.ts Updated the HelperTools enum with the new tool name conventions.
Comments suppressed due to low confidence (1)

src/tools/build.ts:120

  • Since actorFullName is now redundant with the updated naming conventions, consider removing it entirely once the transition to actor-based naming is complete.
        // TODO: remove actorFullName from internal tools

@MQ37 MQ37 merged commit 45ffae6 into master Apr 29, 2025
2 checks passed
@MQ37 MQ37 deleted the fix/rename-tools branch April 29, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ai Issues owned by the AI team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename tools

1 participant