Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -885,9 +885,9 @@ export class CrawlerSetup implements CrawlerSetupOptions {
skipLinksP,
globalStoreP,
logP,
// eslint-disable-next-line @typescript-eslint/await-thenable

requestQueueP,
// eslint-disable-next-line @typescript-eslint/await-thenable

keyValueStoreP,
]);

Expand Down
105 changes: 73 additions & 32 deletions packages/apify/src/charging.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ export class ChargingManager {

private apifyClient: ApifyClient;

constructor(configuration: Configuration, apifyClient: ApifyClient) {
constructor(
private configuration: Configuration,
apifyClient: ApifyClient,
) {
this.maxTotalChargeUsd =
configuration.get('maxTotalChargeUsd') || Infinity; // convert `0` to `Infinity` in case the value is an empty string
this.isAtHome = configuration.get('isAtHome');
Expand All @@ -106,8 +109,6 @@ export class ChargingManager {
'Using the ACTOR_TEST_PAY_PER_EVENT environment variable is only supported in a local development environment',
);
}

this.pricingModel = 'PAY_PER_EVENT';
}

this.apifyClient = apifyClient;
Expand All @@ -117,13 +118,27 @@ export class ChargingManager {
return this.pricingModel === 'PAY_PER_EVENT';
}

/**
* Initialize the ChargingManager by loading pricing information and charging state via Apify API.
*/
async init(): Promise<void> {
this.chargingState = {};
private async fetchPricingInfo(): Promise<{
pricingInfo?: ActorRunPricingInfo;
chargedEventCounts?: Record<string, number>;
maxTotalChargeUsd: number;
}> {
if (
this.configuration.get('actorPricingInfo') &&
this.configuration.get('chargedEventCounts')
) {
return {
pricingInfo: JSON.parse(
this.configuration.get('actorPricingInfo'),
) as ActorRunPricingInfo,
chargedEventCounts: JSON.parse(
this.configuration.get('chargedEventCounts'),
) as Record<string, number>,
maxTotalChargeUsd:
this.configuration.get('maxTotalChargeUsd') || Infinity,
};
}

// Retrieve pricing information
if (this.isAtHome) {
if (this.actorRunId === undefined) {
throw new Error(
Expand All @@ -136,33 +151,59 @@ export class ChargingManager {
throw new Error('Actor run not found');
}

this.pricingModel = run.pricingInfo?.pricingModel;

// Load per-event pricing information
if (run.pricingInfo?.pricingModel === 'PAY_PER_EVENT') {
for (const [eventName, eventPricing] of Object.entries(
run.pricingInfo.pricingPerEvent.actorChargeEvents,
)) {
this.pricingInfo[eventName] = {
price: eventPricing.eventPriceUsd,
title: eventPricing.eventTitle,
};
}

this.maxTotalChargeUsd =
run.options.maxTotalChargeUsd ?? this.maxTotalChargeUsd;
}
return {
pricingInfo: run.pricingInfo,
chargedEventCounts: run.chargedEventCounts,
maxTotalChargeUsd: run.options.maxTotalChargeUsd || Infinity,
};
}

// Load charged event counts
for (const [eventName, chargeCount] of Object.entries(
run.chargedEventCounts ?? {},
return {
pricingInfo: undefined,
chargedEventCounts: {},
maxTotalChargeUsd:
this.configuration.get('maxTotalChargeUsd') || Infinity,
};
}

/**
* Initialize the ChargingManager by loading pricing information and charging state via Apify API.
*/
async init(): Promise<void> {
// Retrieve pricing information
const { pricingInfo, chargedEventCounts, maxTotalChargeUsd } =
await this.fetchPricingInfo();

if (this.configuration.get('testPayPerEvent')) {
this.pricingModel = 'PAY_PER_EVENT';
} else {
Comment on lines +177 to +179
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing e.g. this:

Actor.config.set('testPayPerEvent', true);
await Actor.init();
await Actor.charge({
    eventName: 'my-event',
    count: 1,
});
await Actor.exit();

Will allow enabling the testPayPerEvent mode even on the platform. This wouldn't have been possible before due to this check.

Is this change intentional? Can we move the isAtHome check here to init()? What was the original reason for the check anyway?

this.pricingModel ??= pricingInfo?.pricingModel;
}

// Load per-event pricing information
if (pricingInfo?.pricingModel === 'PAY_PER_EVENT') {
for (const [eventName, eventPricing] of Object.entries(
pricingInfo.pricingPerEvent.actorChargeEvents,
)) {
this.chargingState[eventName] = {
chargeCount,
totalChargedAmount:
chargeCount * (this.pricingInfo[eventName]?.price ?? 0),
this.pricingInfo[eventName] = {
price: eventPricing.eventPriceUsd,
title: eventPricing.eventTitle,
};
}

this.maxTotalChargeUsd = maxTotalChargeUsd;
}

this.chargingState = {};

for (const [eventName, chargeCount] of Object.entries(
chargedEventCounts ?? {},
)) {
this.chargingState[eventName] = {
chargeCount,
totalChargedAmount:
chargeCount * (this.pricingInfo[eventName]?.price ?? 0),
};
}

if (!this.isPayPerEvent || !this.useChargingLogDataset) {
Expand Down
4 changes: 4 additions & 0 deletions packages/apify/src/configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ export interface ConfigurationOptions extends CoreConfigurationOptions {
metaOrigin?: (typeof META_ORIGINS)[keyof typeof META_ORIGINS];
testPayPerEvent?: boolean;
useChargingLogDataset?: boolean;
actorPricingInfo?: string;
chargedEventCounts?: string;
}

/**
Expand Down Expand Up @@ -179,6 +181,8 @@ export class Configuration extends CoreConfiguration {
ACTOR_MAX_TOTAL_CHARGE_USD: 'maxTotalChargeUsd',
ACTOR_TEST_PAY_PER_EVENT: 'testPayPerEvent',
ACTOR_USE_CHARGING_LOG_DATASET: 'useChargingLogDataset',
APIFY_ACTOR_PRICING_INFO: 'actorPricingInfo',
APIFY_CHARGED_ACTOR_EVENT_COUNTS: 'chargedEventCounts',
};

protected static override INTEGER_VARS = [
Expand Down
35 changes: 35 additions & 0 deletions test/apify/charging.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,16 @@ describe('ChargingManager', () => {

afterEach(async () => {
await Actor.exit({ exit: false });

// @ts-expect-error
Actor._instance = undefined; // eslint-disable-line no-underscore-dangle

await localStorageEmulator.destroy();

delete process.env.ACTOR_TEST_PAY_PER_EVENT;
delete process.env.ACTOR_MAX_TOTAL_CHARGE_USD;
delete process.env.APIFY_ACTOR_PRICING_INFO;
delete process.env.APIFY_CHARGED_ACTOR_EVENT_COUNTS;
});

describe('charge()', () => {
Expand All @@ -40,5 +46,34 @@ describe('ChargingManager', () => {
expect(zeroResult.eventChargeLimitReached).toBe(false);
expect(zeroResult.chargedCount).toBe(0);
});

test('should charge events when ACTOR_MAX_TOTAL_CHARGE_USD is set to "" (cost-unlimited)', async () => {
process.env.ACTOR_MAX_TOTAL_CHARGE_USD = '';

// Set pricing info via env vars (as if coming from platform)
process.env.APIFY_ACTOR_PRICING_INFO = JSON.stringify({
pricingModel: 'PAY_PER_EVENT',
pricingPerEvent: {
actorChargeEvents: {
foobar: {
eventTitle: 'Foo bar',
eventPriceUsd: 0.1,
eventDescription: 'Foo foo bar bar',
},
},
},
});
process.env.APIFY_CHARGED_ACTOR_EVENT_COUNTS = JSON.stringify({});

await Actor.init();

const chargeResult = await Actor.charge({
eventName: 'foobar',
count: 4,
});

expect(chargeResult.chargedCount).toBe(4);
expect(chargeResult.eventChargeLimitReached).toBe(false);
});
});
});
Loading