unit - scrapy pipelines actor dataset push

Author: vdusek

tests/unit/scrapy/middlewares/test_apify_proxy.py

@@ -70,7 +70,7 @@ def proxy_configuration() -> ProxyConfiguration:
         'use_apify_proxy_false',
     ],
 )
-def test_middleware_initialization_from_crawler(
+def test_initialization_from_crawler(
     crawler: Crawler,
     monkeypatch: pytest.MonkeyPatch,
     settings: dict,
@@ -92,7 +92,7 @@ def test_middleware_initialization_from_crawler(
     ['http://username:[email protected]:8080', 'http://hsdfgds:[email protected]:5748'],
     ids=['example_proxy', 'apify_proxy'],
 )
-async def test_middleware_retrieves_new_proxy_url(
+async def test_retrieves_new_proxy_url(
     monkeypatch: pytest.MonkeyPatch,
     middleware: ApifyHttpProxyMiddleware,
     proxy_configuration: ProxyConfiguration,
@@ -116,7 +116,7 @@ async def mock_new_url() -> str:
     ],
     ids=['valid_example_proxy', 'valid_apify_proxy', 'invalid_proxy_missing_credentials'],
 )
-async def test_middleware_process_request_with_proxy(
+async def test_process_request_with_proxy(
     monkeypatch: pytest.MonkeyPatch,
     middleware: ApifyHttpProxyMiddleware,
     spider: DummySpider,
@@ -144,7 +144,7 @@ async def mock_get_new_proxy_url() -> ParseResult:
     [TunnelError(), ValueError()],
     ids=['tunnel_error', 'value_error'],
 )
-def test_middleware_handles_exceptions(
+def test_handles_exceptions(
     middleware: ApifyHttpProxyMiddleware,
     spider: DummySpider,
     dummy_request: Request,

tests/unit/scrapy/pipelines/test_actor_dataset_push.py

@@ -43,27 +43,28 @@ class TestCase:
     expected_exception: type[Exception] | None
 
 
-test_cases = [
-    TestCase(
-        item=DummyItem(a='string', b=123, c=False),
-        item_dict={'a': 'string', 'b': 123, 'c': False},
-        expected_exception=None,
-    ),
-    TestCase(
-        item=TitleItem(url='https://example.com', title='Example'),
-        item_dict={'url': 'https://example.com', 'title': 'Example'},
-        expected_exception=None,
-    ),
-    TestCase(
-        item=None,
-        item_dict={},
-        expected_exception=TypeError,
-    ),
-]
-
-
-@pytest.mark.parametrize('tc', test_cases)
-async def test__process_item(
+@pytest.mark.parametrize(
+    'tc',
+    [
+        TestCase(
+            item=DummyItem(a='string', b=123, c=False),
+            item_dict={'a': 'string', 'b': 123, 'c': False},
+            expected_exception=None,
+        ),
+        TestCase(
+            item=TitleItem(url='https://example.com', title='Example'),
+            item_dict={'url': 'https://example.com', 'title': 'Example'},
+            expected_exception=None,
+        ),
+        TestCase(
+            item=None,
+            item_dict={},
+            expected_exception=TypeError,
+        ),
+    ],
+    ids=['dummy_item_with_valid_data', 'title_item_with_valid_data', 'none_item_raises_type_error'],
+)
+async def test_process_item(
     monkeypatch: pytest.MonkeyPatch,
     pipeline: ActorDatasetPushPipeline,
     spider: Spider,