unit - actor

Author: vdusek

tests/unit/actor/test_actor_create_proxy_configuration.py

@@ -24,122 +24,120 @@ def patched_apify_client(apify_client_async_patcher: ApifyClientAsyncPatcher) ->
     return ApifyClientAsync()
 
 
-class TestActorCreateProxyConfiguration:
-    async def test_create_proxy_configuration_basic(
-        self: TestActorCreateProxyConfiguration,
-        monkeypatch: pytest.MonkeyPatch,
-        respx_mock: MockRouter,
-        patched_apify_client: ApifyClientAsync,
-    ) -> None:
-        dummy_proxy_status_url = 'http://dummy-proxy-status-url.com'
-        monkeypatch.setenv(ApifyEnvVars.TOKEN.value, 'DUMMY_TOKEN')
-        monkeypatch.setenv(ApifyEnvVars.PROXY_STATUS_URL.value, dummy_proxy_status_url)
-
-        route = respx_mock.get(dummy_proxy_status_url)
-        route.mock(
-            httpx.Response(
-                200,
-                json={
-                    'connected': True,
-                    'connectionError': None,
-                    'isManInTheMiddle': True,
-                },
-            )
+async def test_basic_proxy_configuration_creation(
+    monkeypatch: pytest.MonkeyPatch,
+    respx_mock: MockRouter,
+    patched_apify_client: ApifyClientAsync,
+) -> None:
+    dummy_proxy_status_url = 'http://dummy-proxy-status-url.com'
+    monkeypatch.setenv(ApifyEnvVars.TOKEN.value, 'DUMMY_TOKEN')
+    monkeypatch.setenv(ApifyEnvVars.PROXY_STATUS_URL.value, dummy_proxy_status_url)
+
+    route = respx_mock.get(dummy_proxy_status_url)
+    route.mock(
+        httpx.Response(
+            200,
+            json={
+                'connected': True,
+                'connectionError': None,
+                'isManInTheMiddle': True,
+            },
         )
+    )
 
-        groups = ['GROUP1', 'GROUP2']
-        country_code = 'US'
-
-        await Actor.init()
-
-        proxy_configuration = await Actor.create_proxy_configuration(groups=groups, country_code=country_code)
-
-        assert proxy_configuration is not None
-        assert proxy_configuration._groups == groups
-        assert proxy_configuration._password == DUMMY_PASSWORD
-        assert proxy_configuration._country_code == country_code
-
-        assert len(patched_apify_client.calls['user']['get']) == 1  # type: ignore
-        assert len(route.calls) == 1
-
-        await Actor.exit()
-
-    async def test_create_proxy_configuration_actor_proxy_input(
-        self: TestActorCreateProxyConfiguration,
-        monkeypatch: pytest.MonkeyPatch,
-        respx_mock: MockRouter,
-        patched_apify_client: ApifyClientAsync,
-    ) -> None:
-        dummy_proxy_status_url = 'http://dummy-proxy-status-url.com'
-        dummy_proxy_url = 'http://dummy-proxy.com:8000'
-
-        monkeypatch.setenv(ApifyEnvVars.TOKEN.value, 'DUMMY_TOKEN')
-        monkeypatch.setenv(ApifyEnvVars.PROXY_STATUS_URL.value, dummy_proxy_status_url)
-
-        route = respx_mock.get(dummy_proxy_status_url)
-        route.mock(
-            httpx.Response(
-                200,
-                json={
-                    'connected': True,
-                    'connectionError': None,
-                    'isManInTheMiddle': True,
-                },
-            )
-        )
+    groups = ['GROUP1', 'GROUP2']
+    country_code = 'US'
 
-        await Actor.init()
+    await Actor.init()
 
-        proxy_configuration = await Actor.create_proxy_configuration(actor_proxy_input={})
-        assert proxy_configuration is None
+    proxy_configuration = await Actor.create_proxy_configuration(groups=groups, country_code=country_code)
 
-        proxy_configuration = await Actor.create_proxy_configuration(
-            actor_proxy_input={
-                'useApifyProxy': False,
-            }
-        )
-        assert proxy_configuration is None
+    assert proxy_configuration is not None
+    assert proxy_configuration._groups == groups
+    assert proxy_configuration._password == DUMMY_PASSWORD
+    assert proxy_configuration._country_code == country_code
 
-        proxy_configuration = await Actor.create_proxy_configuration(
-            actor_proxy_input={
-                'proxyUrls': [],
-            }
-        )
-        assert proxy_configuration is None
+    assert len(patched_apify_client.calls['user']['get']) == 1  # type: ignore
+    assert len(route.calls) == 1
 
-        proxy_configuration = await Actor.create_proxy_configuration(
-            actor_proxy_input={
-                'useApifyProxy': False,
-                'proxyUrls': [dummy_proxy_url],
-            }
-        )
-        assert proxy_configuration is not None
-        assert await proxy_configuration.new_url() == dummy_proxy_url
+    await Actor.exit()
 
-        proxy_configuration = await Actor.create_proxy_configuration(
-            actor_proxy_input={
-                'useApifyProxy': True,
-            }
-        )
-        assert proxy_configuration is not None
-        assert await proxy_configuration.new_url() == f'http://auto:{DUMMY_PASSWORD}@proxy.apify.com:8000'
-
-        groups = ['GROUP1', 'GROUP2']
-        country_code = 'US'
-        proxy_configuration = await Actor.create_proxy_configuration(
-            actor_proxy_input={
-                'useApifyProxy': True,
-                'apifyProxyGroups': groups,
-                'apifyProxyCountry': country_code,
-            }
-        )
-        assert proxy_configuration is not None
-        assert (
-            await proxy_configuration.new_url()
-            == f'http://groups-{"+".join(groups)},country-{country_code}:{DUMMY_PASSWORD}@proxy.apify.com:8000'
-        )
 
-        assert len(patched_apify_client.calls['user']['get']) == 2  # type: ignore
-        assert len(route.calls) == 2
+async def test_proxy_configuration_with_actor_proxy_input(
+    monkeypatch: pytest.MonkeyPatch,
+    respx_mock: MockRouter,
+    patched_apify_client: ApifyClientAsync,
+) -> None:
+    dummy_proxy_status_url = 'http://dummy-proxy-status-url.com'
+    dummy_proxy_url = 'http://dummy-proxy.com:8000'
 
-        await Actor.exit()
+    monkeypatch.setenv(ApifyEnvVars.TOKEN.value, 'DUMMY_TOKEN')
+    monkeypatch.setenv(ApifyEnvVars.PROXY_STATUS_URL.value, dummy_proxy_status_url)
+
+    route = respx_mock.get(dummy_proxy_status_url)
+    route.mock(
+        httpx.Response(
+            200,
+            json={
+                'connected': True,
+                'connectionError': None,
+                'isManInTheMiddle': True,
+            },
+        )
+    )
+
+    await Actor.init()
+
+    proxy_configuration = await Actor.create_proxy_configuration(actor_proxy_input={})
+    assert proxy_configuration is None
+
+    proxy_configuration = await Actor.create_proxy_configuration(
+        actor_proxy_input={
+            'useApifyProxy': False,
+        }
+    )
+    assert proxy_configuration is None
+
+    proxy_configuration = await Actor.create_proxy_configuration(
+        actor_proxy_input={
+            'proxyUrls': [],
+        }
+    )
+    assert proxy_configuration is None
+
+    proxy_configuration = await Actor.create_proxy_configuration(
+        actor_proxy_input={
+            'useApifyProxy': False,
+            'proxyUrls': [dummy_proxy_url],
+        }
+    )
+    assert proxy_configuration is not None
+    assert await proxy_configuration.new_url() == dummy_proxy_url
+
+    proxy_configuration = await Actor.create_proxy_configuration(
+        actor_proxy_input={
+            'useApifyProxy': True,
+        }
+    )
+    assert proxy_configuration is not None
+    assert await proxy_configuration.new_url() == f'http://auto:{DUMMY_PASSWORD}@proxy.apify.com:8000'
+
+    groups = ['GROUP1', 'GROUP2']
+    country_code = 'US'
+    proxy_configuration = await Actor.create_proxy_configuration(
+        actor_proxy_input={
+            'useApifyProxy': True,
+            'apifyProxyGroups': groups,
+            'apifyProxyCountry': country_code,
+        }
+    )
+    assert proxy_configuration is not None
+    assert (
+        await proxy_configuration.new_url()
+        == f'http://groups-{"+".join(groups)},country-{country_code}:{DUMMY_PASSWORD}@proxy.apify.com:8000'
+    )
+
+    assert len(patched_apify_client.calls['user']['get']) == 2  # type: ignore
+    assert len(route.calls) == 2
+
+    await Actor.exit()

tests/unit/actor/test_actor_dataset.py

@@ -15,51 +15,50 @@
 # Actual tests for the implementations are in storages/.
 
 
-class TestActorOpenDataset:
-    async def test_throws_without_init(self: TestActorOpenDataset) -> None:
-        with pytest.raises(RuntimeError):
-            await Actor.open_dataset()
-
-    async def test_same_references(self: TestActorOpenDataset) -> None:
-        async with Actor:
-            dataset1 = await Actor.open_dataset()
-            dataset2 = await Actor.open_dataset()
-            assert dataset1 is dataset2
-
-            dataset_name = 'non-default'
-            dataset_by_name_1 = await Actor.open_dataset(name=dataset_name)
-            dataset_by_name_2 = await Actor.open_dataset(name=dataset_name)
-            assert dataset_by_name_1 is dataset_by_name_2
-
-            dataset_by_id_1 = await Actor.open_dataset(id=dataset_by_name_1._id)
-            dataset_by_id_2 = await Actor.open_dataset(id=dataset_by_name_1._id)
-
-            assert dataset_by_id_1 is dataset_by_name_1
-            assert dataset_by_id_2 is dataset_by_id_1
-
-    async def test_open_datatset_based_env_var(
-        self: TestActorOpenDataset,
-        monkeypatch: pytest.MonkeyPatch,
-        memory_storage_client: MemoryStorageClient,
-    ) -> None:
-        default_dataset_id = 'my-new-default-id'
-        monkeypatch.setenv(ActorEnvVars.DEFAULT_DATASET_ID, default_dataset_id)
-
-        async with Actor:
-            ddt = await Actor.open_dataset()
-            assert ddt._id == default_dataset_id
-            await memory_storage_client.dataset(ddt._id).delete()
-
-
-class TestActorPushData:
-    async def test_push_data(self: TestActorPushData) -> None:
-        async with Actor as my_actor:
-            dataset = await my_actor.open_dataset()
-            desired_item_count = 100
-            await dataset.push_data([{'id': i} for i in range(desired_item_count)])
-
-            dataset_info = await dataset.get_info()
-            assert dataset_info is not None
-
-            list_page = await dataset.get_data(limit=desired_item_count)
-            assert {item['id'] for item in list_page.items} == set(range(desired_item_count))
+async def test_throws_error_without_actor_init() -> None:
+    with pytest.raises(RuntimeError):
+        await Actor.open_dataset()
+
+
+async def test_open_dataset_returns_same_references() -> None:
+    async with Actor:
+        dataset1 = await Actor.open_dataset()
+        dataset2 = await Actor.open_dataset()
+        assert dataset1 is dataset2
+
+        dataset_name = 'non-default'
+        dataset_by_name_1 = await Actor.open_dataset(name=dataset_name)
+        dataset_by_name_2 = await Actor.open_dataset(name=dataset_name)
+        assert dataset_by_name_1 is dataset_by_name_2
+
+        dataset_by_id_1 = await Actor.open_dataset(id=dataset_by_name_1._id)
+        dataset_by_id_2 = await Actor.open_dataset(id=dataset_by_name_1._id)
+
+        assert dataset_by_id_1 is dataset_by_name_1
+        assert dataset_by_id_2 is dataset_by_id_1
+
+
+async def test_open_dataset_uses_env_var(
+    monkeypatch: pytest.MonkeyPatch,
+    memory_storage_client: MemoryStorageClient,
+) -> None:
+    default_dataset_id = 'my-new-default-id'
+    monkeypatch.setenv(ActorEnvVars.DEFAULT_DATASET_ID, default_dataset_id)
+
+    async with Actor:
+        ddt = await Actor.open_dataset()
+        assert ddt._id == default_dataset_id
+        await memory_storage_client.dataset(ddt._id).delete()
+
+
+async def test_push_data_to_dataset() -> None:
+    async with Actor as my_actor:
+        dataset = await my_actor.open_dataset()
+        desired_item_count = 100
+        await dataset.push_data([{'id': i} for i in range(desired_item_count)])
+
+        dataset_info = await dataset.get_info()
+        assert dataset_info is not None
+
+        list_page = await dataset.get_data(limit=desired_item_count)
+        assert {item['id'] for item in list_page.items} == set(range(desired_item_count))

tests/unit/actor/test_actor_env_helpers.py

@@ -23,21 +23,21 @@
     import pytest
 
 
-async def test_is_at_home_local() -> None:
+async def test_actor_is_not_at_home_when_local() -> None:
     async with Actor as actor:
         is_at_home = actor.is_at_home()
         assert is_at_home is False
 
 
-async def test_is_at_home_on_apify(monkeypatch: pytest.MonkeyPatch) -> None:
+async def test_actor_is_at_home_on_apify(monkeypatch: pytest.MonkeyPatch) -> None:
     print('setenv')
     monkeypatch.setenv(ApifyEnvVars.IS_AT_HOME, 'true')
     async with Actor as actor:
         is_at_home = actor.is_at_home()
         assert is_at_home is True
 
 
-async def test_get_env_use_env_vars(monkeypatch: pytest.MonkeyPatch) -> None:
+async def test_get_env_with_randomized_env_vars(monkeypatch: pytest.MonkeyPatch) -> None:
     ignored_env_vars = {
         ApifyEnvVars.INPUT_KEY,
         ApifyEnvVars.MEMORY_MBYTES,