Skip to content

Conversation

DanielAvdar
Copy link

@DanielAvdar DanielAvdar commented Feb 15, 2024

Migrate to Poetry for packaging and dependency management #156

@DanielAvdar DanielAvdar marked this pull request as ready for review February 15, 2024 17:54
@DanielAvdar DanielAvdar had a problem deploying to fork-pr-integration-tests February 16, 2024 08:48 — with GitHub Actions Failure
@DanielAvdar DanielAvdar had a problem deploying to fork-pr-integration-tests February 16, 2024 08:56 — with GitHub Actions Failure
@DanielAvdar DanielAvdar had a problem deploying to fork-pr-integration-tests February 16, 2024 18:32 — with GitHub Actions Failure
@DanielAvdar DanielAvdar had a problem deploying to fork-pr-integration-tests February 16, 2024 19:14 — with GitHub Actions Failure
Signed-off-by: DanielAvdar <[email protected]>
@DanielAvdar DanielAvdar had a problem deploying to fork-pr-integration-tests February 17, 2024 13:43 — with GitHub Actions Failure
@vdusek
Copy link
Contributor

vdusek commented Feb 20, 2024

Hi @DanielAvdar, migration to Poetry was planned in Q2-Q3 of this year, after we thoroughly tested it in our internal repositories. Also, I believe twine could be replaced by poetry as well. Definitely, thank you for the contribution, however, we'll come back to this PR in a few months, once migration to Poetry in SDK is on the table.

@DanielAvdar
Copy link
Author

Hi @DanielAvdar, migration to Poetry was planned in Q2-Q3 of this year, after we thoroughly tested it in our internal repositories. Also, I believe twine could be replaced by poetry as well. Definitely, thank you for the contribution, however, we'll come back to this PR in a few months, once migration to Poetry in SDK is on the table.

@vdusek Indeed, Twine can be replaced. This PR simply adds Poetry support, and everything else should work the same as before.

Signed-off-by: DanielAvdar <[email protected]>
@DanielAvdar DanielAvdar had a problem deploying to fork-pr-integration-tests February 20, 2024 08:12 — with GitHub Actions Failure
@DanielAvdar DanielAvdar changed the title Poetry Migration Add Poetry Support Feb 20, 2024
@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 5, 2024
@vdusek
Copy link
Contributor

vdusek commented Aug 28, 2024

Closing as Poetry was added in #247.

@vdusek vdusek closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants