Skip to content

fix: Hotfix for batch_add_requests batch size limit #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2024
Merged

fix: Hotfix for batch_add_requests batch size limit #261

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a095194
Hotfix for batch_add_requests batch size limit
janbuchar Sep 4, 2024
faf4180
Merge remote-tracking branch 'origin/master' into hotfix-batch-add-re…
janbuchar Sep 5, 2024
dc7298e
Comment
janbuchar Sep 5, 2024
9d48a6a
Add integration tests
janbuchar Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/apify/apify_storage_client/_request_queue_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from typing import TYPE_CHECKING

from more_itertools import chunked
from typing_extensions import override

from crawlee import Request
Expand Down Expand Up @@ -157,8 +158,11 @@ async def batch_add_requests(
*,
forefront: bool = False,
) -> BatchRequestsOperationResponse:
return BatchRequestsOperationResponse.model_validate(
await self._client.batch_add_requests(
processed = []
unprocessed = []

for chunk in chunked(requests, 25):
response = await self._client.batch_add_requests(
requests=[
r.model_dump(
by_alias=True,
Expand All @@ -170,10 +174,18 @@ async def batch_add_requests(
'data',
},
)
for r in requests
for r in chunk
],
forefront=forefront,
)
processed.extend(response['processedRequests'])
unprocessed.extend(response['unprocessedRequests'])

return BatchRequestsOperationResponse.model_validate(
{
'processedRequests': processed,
'unprocessedRequests': unprocessed,
}
)

@override
Expand Down
Loading