Skip to content

chore: revert hotfix for batch add requests in client #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore: revert hotfix for batch add requests in client #277

merged 1 commit into from
Sep 18, 2024

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Sep 17, 2024 •
edited
Loading

reverting #261

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Sep 17, 2024
@vdusek vdusek added this to the 98th sprint - Tooling team milestone Sep 17, 2024
@vdusek vdusek requested a review from janbuchar September 17, 2024 14:58
@vdusek vdusek self-assigned this Sep 17, 2024
@janbuchar
Copy link
Contributor

Did you test this on the platform? Or should I do it?

janbuchar
janbuchar approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@janbuchar janbuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is legit, if integration tests pass, it should be enough 🙂

@vdusek
Copy link
Contributor Author

vdusek commented Sep 18, 2024 •
edited
Loading

The code is legit, if integration tests pass, it should be enough 🙂

Yep, I believe in your integration tests 🙂

@vdusek vdusek merged commit 983963a into master Sep 18, 2024
22 checks passed
@vdusek vdusek deleted the revert-hotfix-for-batch-add-requests branch September 18, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janbuchar janbuchar janbuchar approved these changes

Assignees

@vdusek vdusek

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Milestone

98th sprint - Tooling team

Development

Successfully merging this pull request may close these issues.

2 participants

@vdusek @janbuchar