Skip to content

test: Do not expect event handlers to be executed in any order #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
+6 −6
Merged

test: Do not expect event handlers to be executed in any order #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c70ebba
Do not expect event handlers to be executed in any order
janbuchar Nov 8, 2024
c288eab
Fix noqa directive
janbuchar Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/apify/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@


@ignore_docs
class ActorLogFormatter(CrawleeLogFormatter): # noqa: D101 Inherited from parent class
class ActorLogFormatter(CrawleeLogFormatter): # noqa: D101 (Inherited from parent class)
pass


Expand Down
10 changes: 5 additions & 5 deletions tests/unit/test_platform_event_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,24 +75,24 @@ def event_handler(data: Any) -> None:

dummy_persist_state = Mock()

# Test that they all work, and that they're called in order
# Test that they all work
event_manager.emit(event=Event.PERSIST_STATE, event_data=dummy_persist_state)
await asyncio.sleep(0.1)
assert event_calls[Event.PERSIST_STATE] == [
assert set(event_calls[Event.PERSIST_STATE]) == {
(1, dummy_persist_state),
(2, dummy_persist_state),
(3, dummy_persist_state),
]
}
event_calls[Event.PERSIST_STATE].clear()

# Test that if you remove one, the others stay
event_manager.off(event=Event.PERSIST_STATE, listener=handler_persist_state_3)
event_manager.emit(event=Event.PERSIST_STATE, event_data=dummy_persist_state)
await asyncio.sleep(0.1)
assert event_calls[Event.PERSIST_STATE] == [
assert set(event_calls[Event.PERSIST_STATE]) == {
(1, dummy_persist_state),
(2, dummy_persist_state),
]
}
event_calls[Event.PERSIST_STATE].clear()

# Test that removing all in bulk works
Expand Down