Skip to content

chore: Use specific rule codes when ignoring type issues #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

chore: Use specific rule codes when ignoring type issues #345

merged 1 commit into from
Nov 29, 2024

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Nov 29, 2024 •
edited
Loading

  • Rm ignore of PGH003 rule and update type ignores to be specific.
  • Rm the comment about deps in the pyprojtoml, as it is obvious now probably.

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Nov 29, 2024
@vdusek vdusek added this to the 103rd sprint - Tooling team milestone Nov 29, 2024
@vdusek vdusek self-assigned this Nov 29, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Nov 29, 2024
@vdusek vdusek requested a review from Pijukatel November 29, 2024 07:43
@vdusek vdusek merged commit 0a4c65b into master Nov 29, 2024
28 of 30 checks passed
@vdusek vdusek deleted the be-specific-about-type-ignores branch November 29, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pijukatel Pijukatel Pijukatel approved these changes

Assignees

@vdusek vdusek

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
103rd sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
2 participants
@vdusek @Pijukatel