-
Notifications
You must be signed in to change notification settings - Fork 15
refactor!: Make Actor
initialization stricter and more predictable
#576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 50 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
8369ff9
Test with crawlee branch `storage-clients-and-configurations`
Pijukatel d9137aa
Add debug
Pijukatel cf1ee6f
Update config handling
Pijukatel d6b85ac
Add many configuration based tests
Pijukatel ea8e085
Add storage tests
Pijukatel 9c3e7b1
Do Pydantic workaround
Pijukatel a2825bf
Wip, TODO: Solve patching of service_locator from Crawlee
Pijukatel 0b96454
Update lock
Pijukatel 432c79c
Remove any monkey patching from Configuration
Pijukatel a4a046e
Move all relevant initialization for Actor from __init__ to init to e…
Pijukatel 2a52cdc
Update inits
Pijukatel 841d89a
Update tests
Pijukatel 8bd59fd
Fix failing tests
Pijukatel c4b5d48
Remove leftover edits
Pijukatel 19ea5c7
Update init regarding the implicit config finalization
Pijukatel 54a3523
Finalize tests
Pijukatel c89fd73
Merge remote-tracking branch 'origin/master' into test-new-storage-se…
Pijukatel b4efbff
Properly set implicit ApifyFileSystemStorageClient
Pijukatel 6a6ab98
Update test
Pijukatel f1ce0d1
Review feedback
Pijukatel 8347eb6
Merge remote-tracking branch 'origin/master' into test-new-storage-se…
Pijukatel b7101a4
Master related update
Pijukatel 19b79f1
Add upgrading guide
Pijukatel b256876
Add migration test
Pijukatel 6fbb5f4
Ensure proper storoage client init when is_at_home to avoid unnecesar…
Pijukatel 5bf51f7
Add warning for usage of FileSystemStorageClient in Actor context
Pijukatel 14c5395
Add special caching for ApifyClient
Pijukatel f7c9a58
Remove line that is no longer necessary
Pijukatel 4450bf8
Update lock
Pijukatel f28fcd7
Merge remote-tracking branch 'origin/master' into test-new-storage-se…
Pijukatel c2c8ca5
Update NDU creation logic based on updated Crawlee
Pijukatel 7911c48
Update tests
Pijukatel e68bdef
Update lock
Pijukatel 04e74bc
Review comments
Pijukatel 1cb295f
Do not attempt to deal with limited retention for alias storages locally
Pijukatel 4b5946f
Add more docstrings
Pijukatel 70890e7
Review call changes
Pijukatel 2d61f1e
Review call changes 2
Pijukatel 3813ea3
Add docs and compute_short_hash for additional cache key
Pijukatel 5608b4d
Remove Actor.config
Pijukatel 4b6c414
crawler actor reboot test
Pijukatel 79b0ff7
Move test_apify_storages
Pijukatel b424c9b
Update test_configuration.py
Pijukatel cae107e
Update typing
Pijukatel 177dbb2
Fix naming in failing test
Pijukatel 698c089
Add warning to potential missuse of Configuration
Pijukatel 3b7634a
Update caplog test
Pijukatel 0de39ad
Revert lock changes
Pijukatel b19ea8c
Review comments
Pijukatel 85bf04d
Remove unused self._charging_manager
Pijukatel 47f84eb
Apply suggestions from code review
Pijukatel 7d1fc84
Review comments
Pijukatel 35ad0dd
Remove difference in storage clients
Pijukatel 28ebd8d
inline finalize
vdusek f884356
Order methods in AliasResolver
Pijukatel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.