feat(input_schema): datepicker allowAbsolute/allowRelative properties and validation #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfori
added
the
t-console
mfori
changed the title
drobnikj
requested changes
Sep 25, 2024
Update schema.json to not accept both sets to `false` Create unit tests
github-actions
bot
added
the
tested
drobnikj
requested changes
Sep 26, 2024
| allowAbsolute: false, | ||
| }, | ||
| }, | ||
| })).toBe(false); |
There was a problem hiding this comment.
I would rather test if the error message is correct as the logic is not trivial.
There was a problem hiding this comment.
Added check of error messages
| allowRelative: false, | ||
| }, | ||
| }, | ||
| })).toBe(false); |
indentation Co-authored-by: Martin Adámek <[email protected]>
mfori
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce new input_schema properties
allowAbsoluteandallowRelativeused when theeditorproperty is set todatepicker:schema.jsonis updated in the way, that propertiesallowAbsoluteandallowRelativeare valid only wheneditorisdatepicker,allowAbsoluteis considered as default and any ofallowAbsoluteorallowRelativeis true