Skip to content

Conversation

@novotnyj
Copy link
Member

@novotnyj novotnyj commented Oct 8, 2024

Needed to add maxCostPerRunUsd from run options to actor env vars.

@github-actions github-actions bot added the t-c&c Team covering store and finance matters. label Oct 8, 2024
@novotnyj novotnyj changed the title Feat/add max cost per run feat: add max cost per run Oct 8, 2024
@jirimoravcik
Copy link
Member

@novotnyj
Copy link
Member Author

novotnyj commented Oct 8, 2024

@mhamas Looking at https://github.com/apify/actor-whitepaper?tab=readme-ov-file#environment-variables - maybe we should use ACTOR_MAX_TOTAL_CHARGE_USD for this?

@jancurn
Copy link
Member

jancurn commented Oct 8, 2024

Yes, I called this ACTOR_MAX_TOTAL_CHARGE_USD because the function is called Actor.charge(), for consistency. Also, the word "cost" is used on platform in the context of platform costs, which is typically lower than what is charged, because devs have margin. From point of view of the developer, "costs" is their costs, not what they charge their users.

@jancurn
Copy link
Member

jancurn commented Oct 8, 2024

@novotnyj @mhamas thanks for this, just pls guys can you make the naming consistent also on the platform?

Copy link
Contributor

@mhamas mhamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @novotnyj and we can rename this on platform as well. @novotnyj can you create a ticket for this into this sprint and do it with higher priority, co we can get it done before it actually starts to be properly used. Thx

@novotnyj
Copy link
Member Author

novotnyj commented Oct 8, 2024

@novotnyj novotnyj merged commit 01588f5 into master Oct 15, 2024
9 checks passed
@novotnyj novotnyj deleted the feat/add-max-cost-per-run branch October 15, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-c&c Team covering store and finance matters.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants