- 
                Notifications
    
You must be signed in to change notification settings  - Fork 11
 
feat(input_schema): datepicker dateType property #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "editor": { "enum": ["javascript", "python", "textfield", "textarea", "datepicker", "hidden"] }, | ||
| "isSecret": { "type": "boolean" }, | ||
| "editor": { "enum": ["javascript", "python", "textfield", "textarea", "hidden"] }, | ||
| "isSecret": { "enum": [false] }, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to force it to just a single value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already after the
"if": {
    properties": {
        "isSecret": {
            "not": {
                "const": true
             }
         }
    }
},
So there can't be any other boolean value then false. It's not necessary but I like it in the same way I did with:
"editor": { "enum": ["datepicker"] },
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand this, this is a breaking change, because suddenly the input schemas with the old allowAbsolute etc. properties will be invalid. Just to be sure, is that OK? Were they not documented anywhere yet? Are there no Actors with input schemas containing those properties?
Otherwise looks good.
          
 Yes, these old values   | 
    
This PR replace
allowAbsolute/allowRelativeboolean properties for datepicker with singledateTypeproperty that accepts valuesabsolute,relativeandabsoluteOrRelativebased on:dateTypeproperty:editorisdatepicker