feat(consts): introduce profile name (first, last, organization, ...) restrictions and adjust username regex #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveHanns
commented
Nov 4, 2024
DaveHanns
commented
Nov 4, 2024
B4nan
reviewed
Nov 4, 2024
DaveHanns
commented
Nov 4, 2024
github-actions
bot
added
t-console
baldasseva
reviewed
Nov 5, 2024
baldasseva
approved these changes
Nov 5, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
valekjo
approved these changes
Nov 6, 2024
gippy
approved these changes
Nov 6, 2024
DaveHanns
changed the title
DaveHanns
force-pushed
the
fix/prevent-url-username
branch
from
8fc35d8 to
bfa283d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects https://github.com/apify/apify-core/issues/17545
Besides introduction of new Profile name restrictions, this also adjusts restrictions (regex) of valid username.
It does so to prevent users from inputing viable url addresses by removing a dot from allowed characters. By doing so, the username now cannot form a valid URL or Email domain.
See comment bellow for more info (@baldasseva mainly).