Skip to content

Conversation

@mfori
Copy link
Member

@mfori mfori commented Dec 2, 2024

Needed to solve https://github.com/apify/apify-core/issues/18466.
Now the rel="noopener noreferrer nofollow" target="_blank" is added only if url is outside from apify.com domain.
This enable passing hostname to markedSetNofollowLinks function and setting rel="noopener noreferrer" target="_blank" for apify domain but different hostname.

Once this is merged, next step would be to pass hostname from safeMarkdown in console/frontend down to markedSetNofollowLinks

@mfori mfori added the t-console Issues with this label are in the ownership of the console team. label Dec 2, 2024
@mfori mfori requested review from B4nan and gippy December 2, 2024 15:38
@mfori mfori self-assigned this Dec 2, 2024
@github-actions github-actions bot added this to the 104th sprint - Console team milestone Dec 2, 2024
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Dec 2, 2024
@B4nan B4nan requested review from barjin and removed request for B4nan December 2, 2024 17:17
Copy link
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfori I don't think our team (@B4nan or me) should have any say in this 😅 It looks safe to me, but I'd rather have somebody more web-devvy check this. Nevertheless, I left a few curious comments, feel free to ignore both :)

@mfori
Copy link
Member Author

mfori commented Dec 3, 2024

@mfori I don't think our team (@B4nan or me) should have any say in this 😅 It looks safe to me, but I'd rather have somebody more web-devvy check this. Nevertheless, I left a few curious comments, feel free to ignore both :)

Sorry for that, but according to git history @B4nan wrote majority of this file, but maybe he just moved it, I don't know

@B4nan
Copy link
Member

B4nan commented Dec 3, 2024

I rewrote the whole codebase to TS and moved it to a monorepo :)

@mfori mfori requested a review from drobnikj December 3, 2024 12:54
Copy link
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this more, I'm all for merging this - now I see it just adds a new branch for Apify links from a different hostname, the rest of the code is untouched. LGTM, thanks!

Copy link
Member

@drobnikj drobnikj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfori mfori merged commit 59d746d into master Dec 4, 2024
9 checks passed
@mfori mfori deleted the feat/18466-set-no-follow-links branch December 4, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-console Issues with this label are in the ownership of the console team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants