Skip to content

feat: add support for SOCKS to PROXY_URL_REGEX #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat: add support for SOCKS to PROXY_URL_REGEX #498

merged 2 commits into from
Jan 21, 2025

Conversation

@jirimoravcik
Copy link
Member

@jirimoravcik jirimoravcik commented Jan 17, 2025

This PR adds support for SOCKS protocols into the PROXY_URL_REGEX. I also added unit tests for it while I was at it.

@jirimoravcik jirimoravcik added the adhoc Ad-hoc unplanned task added during the sprint. label Jan 17, 2025
@jirimoravcik jirimoravcik requested a review from Copilot January 17, 2025 14:47
@github-actions github-actions bot added this to the 107th sprint - Platform team milestone Jan 17, 2025
@github-actions github-actions bot added t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. labels Jan 17, 2025
Copilot AI reviewed Jan 17, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@jirimoravcik jirimoravcik merged commit b114d33 into master Jan 21, 2025
9 checks passed
@jirimoravcik jirimoravcik deleted the feat/add-socks-to-proxy-url-regex branch January 21, 2025 13:41
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@fnesveda fnesveda fnesveda approved these changes

@gippy gippy Awaiting requested review from gippy

Assignees

@jirimoravcik jirimoravcik

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Projects

None yet

Milestone

107th sprint - Platform team

Development

Successfully merging this pull request may close these issues.

2 participants

@jirimoravcik @fnesveda