feat: parse boolean utility function #577
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-core-services
Member
|
Also relevant for MCP as we recently added the same function there https://github.com/apify/apify-mcp-server/blob/master/src/utils/generic.ts#L75 |
valekjo
approved these changes
Nov 28, 2025
Member
valekjo
left a comment
valekjo
left a comment
There was a problem hiding this comment.
Looks good. I'd add an issue to replace the parseBooleanParameter in the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces simple new
parseBooleanOrNullutility function to parse boolean from string.If value is stringbool, then the function return
true/false.if the value is invalid, then the function return
null, which is I think the best as we can distinguish between valid and invalid input, but also null is falsy value, so we can use it as false in condition.In many repos, we do not use Zod validator which can handle this using coerce api, and it would be a very heavy dependency for just this usecase.