-
Notifications
You must be signed in to change notification settings - Fork 487
refactor!: Refactor storage creation and caching, configuration and services #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a3aa0e3
WIP
Pijukatel be54e46
Draft for discussion.
Pijukatel 9c6a521
Remove temp edits for e2e tests
Pijukatel 86c4244
Simplify types
Pijukatel dd5f914
Update configuration according to Pydantic docs recommendation
Pijukatel df06b82
Properly create custom storage clients when p[assing custom configura…
Pijukatel 430f2ad
Update the create methods
Pijukatel 1340c5c
Add global instanc manager
Pijukatel a1746f3
Try to keep config in open, but rework the instance cache
Pijukatel e86356d
Properly set global_storage_instance_manager
Pijukatel 07ffa19
Avoid coroutine ... was never awaited
Pijukatel 6026b3a
Revert incorrect delete, add test that would catch it, remove useless…
Pijukatel 330b598
Revert unintentional edit in base class
Pijukatel 8143277
Parametrize storage_instance_manager tests by storage type
Pijukatel ed4bca7
Extract shared fixture and remove unused fixtures
Pijukatel b06054b
Update upgrading guide
Pijukatel fa2703b
Merge remote-tracking branch 'origin/master' into storage-clients-and…
Pijukatel 97055ee
Apply suggestions from code review
Pijukatel 6affd8b
Review comments
Pijukatel 1706ed8
Renamed client_opener to client_opener_coro
Pijukatel 6ccd4f7
Update src/crawlee/storages/_storage_instance_manager.py
Pijukatel 043d308
Review comments
Pijukatel 0ff47c8
Update pyproject.toml
Pijukatel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.