fix: Add storages name validation #1457
Open
+259
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mantisus
requested review from
vdusek and
Pijukatel
and removed request for
vdusek
|
assigning @janbuchar as @Pijukatel is off for this week |
vdusek
reviewed
Oct 7, 2025
There was a problem hiding this comment.
Thanks. I'm wondering, shouldn't we add this new enforcement on this level to https://crawlee.dev/python/docs/upgrading/upgrading-to-v1?
Comment on lines
+1058
to
+1077
| @pytest.mark.parametrize( | ||
| ('name', 'is_valid'), | ||
| [ | ||
| pytest.param('F', True, id='single-char'), | ||
| pytest.param('7', True, id='single-digit'), | ||
| pytest.param('FtghdfseySds', True, id='mixed-case'), | ||
| pytest.param('125673450', True, id='all-digits'), | ||
| pytest.param('Ft2134Sfe0O1hf', True, id='mixed-alphanumeric'), | ||
| pytest.param('name-with-dashes', True, id='dashes'), | ||
| pytest.param('1-value', True, id='number start'), | ||
| pytest.param('value-1', True, id='number end'), | ||
| pytest.param('test-1-value', True, id='number middle'), | ||
| pytest.param('test-------value', True, id='multiple-dashes'), | ||
| pytest.param('test-VALUES-test', True, id='multiple-cases'), | ||
| pytest.param('name_with_underscores', False, id='underscores'), | ||
| pytest.param('name with spaces', False, id='spaces'), | ||
| pytest.param('-test', False, id='dashes start'), | ||
| pytest.param('test-', False, id='dashes end'), | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Does this also correspond to the naming constraints in SqlStorageClient?
janbuchar
approved these changes
Oct 7, 2025
Co-authored-by: Vlada Dusek <[email protected]>
Co-authored-by: Vlada Dusek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
Testing