Skip to content

test: Add end-to-end test of AdaptivePlaywrightCrawler#3003

Merged
janbuchar merged 5 commits intomasterfrom
adaptive-crawler-e2e-test
Jun 10, 2025
Merged

test: Add end-to-end test of AdaptivePlaywrightCrawler#3003
janbuchar merged 5 commits intomasterfrom
adaptive-crawler-e2e-test

Conversation

@janbuchar
Copy link
Contributor

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 9, 2025
@janbuchar janbuchar requested review from B4nan and barjin June 9, 2025 17:38
@github-actions github-actions bot added this to the 116th sprint - Tooling team milestone Jun 9, 2025
@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jun 9, 2025
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits, also some files are missing the final line break

janbuchar and others added 3 commits June 10, 2025 10:27
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@B4nan
Copy link
Member

B4nan commented Jun 10, 2025

hmm fails on the platform, my guess is we use old better sqlite version which doesnt have prebuilds for node 22. i hacked this in the existing e2e test like this:

"@apify/storage-local": {
"better-sqlite3": "^11.10.0"
}

@janbuchar
Copy link
Contributor Author

hmm fails on the platform, my guess is we use old better sqlite version which doesnt have prebuilds for node 22. i hacked this in the existing e2e test like this:

"@apify/storage-local": {
"better-sqlite3": "^11.10.0"
}

adaptive-playwright-robots-file runs on node 20 😉

@B4nan
Copy link
Member

B4nan commented Jun 10, 2025

this is from v4 branch where its already bumped (but not sure if it actually works)

https://github.com/apify/crawlee/blob/b78ee6901f5f336b0ec2dcb18f46da1f876068b8/test/e2e/adaptive-playwright-robots-file/actor/Dockerfile

@janbuchar
Copy link
Contributor Author

@janbuchar janbuchar merged commit cf72d70 into master Jun 10, 2025
12 checks passed
@janbuchar janbuchar deleted the adaptive-crawler-e2e-test branch June 10, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write an e2e test of adaptive playwright crawler

2 participants