Skip to content

feat: add collectAllKeys option for BasicCrawler.exportData#3129

Merged
barjin merged 2 commits intomasterfrom
csv/collect-all-keys-crawler
Aug 13, 2025
Merged

feat: add collectAllKeys option for BasicCrawler.exportData#3129
barjin merged 2 commits intomasterfrom
csv/collect-all-keys-crawler

Conversation

@barjin
Copy link
Member

@barjin barjin commented Aug 12, 2025

Ports the collectAllKeys option from #3007 to the BasicCrawler.exportData method. Dataset.exportTo and BasicCrawler.exportData seem way too similar for this omission to be intentional. If it is so, feel free to close this PR.

@barjin barjin requested review from Copilot and janbuchar August 12, 2025 12:48
@barjin barjin self-assigned this Aug 12, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Aug 12, 2025
@github-actions github-actions bot added this to the 121st sprint - Tooling team milestone Aug 12, 2025
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Aug 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@barjin barjin merged commit 2ddfc9c into master Aug 13, 2025
11 checks passed
@barjin barjin deleted the csv/collect-all-keys-crawler branch August 13, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants