chore: run clippy in the formatting CI workflow

Author: barjin

.github/workflows/cli-release.yaml

@@ -10,6 +10,7 @@ on:
     paths:
       - "impit-cli/**"
       - "impit/**"
+  workflow_dispatch:
 
 env:
   CRATE_NAME: impit-cli

.github/workflows/format.yaml

@@ -5,9 +5,12 @@ on:
       - master
   pull_request:
 
+env:
+  RUSTFLAGS: "--cfg reqwest_unstable"
+
 jobs:
   fmt:
-    name: Check code formatting
+    name: rustfmt
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -17,4 +20,16 @@ jobs:
           components: rustfmt
 
       - name: Rustfmt Check
-        uses: actions-rust-lang/rustfmt@v1
+        uses: actions-rust-lang/rustfmt@v1
+  clippy:
+    name: clippy
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          components: clippy
+
+      - name: Run clippy
+        run: cargo clippy --all --manifest-path=./Cargo.toml -- -D warnings

impit-cli/Cargo.toml

@@ -9,13 +9,16 @@ edition = "2021"
 clap = { version = "4.5.21", features = ["derive"] }
 impit = { path="../impit" }
 tokio = { version="1.41.1", features = ["full"] }
-aws-lc-rs = { version = "1.11.1", features = ["bindgen"] }
+aws-lc-rs = { version = "1.11.1" }
 
 [target.x86_64-unknown-linux-musl.dependencies]
 openssl = { version = "*", features = ["vendored"] }
+aws-lc-rs = { version = "1.11.1" features = ["bindgen"] }
 
 [target.aarch64-unknown-linux-musl.dependencies]
 openssl = { version = "*", features = ["vendored"] }
+aws-lc-rs = { version = "1.11.1" features = ["bindgen"] }
 
 [target.arm-unknown-linux-musleabi.dependencies]
 openssl = { version = "*", features = ["vendored"] }
+aws-lc-rs = { version = "1.11.1" features = ["bindgen"] }

impit/src/response_parsing/mod.rs

@@ -4,7 +4,7 @@ use encoding::Encoding;
 /// If the BOM sniffing algorithm fails, the function returns `None`.
 ///
 /// See more details at https://encoding.spec.whatwg.org/#bom-sniff
-fn bom_sniffing(bytes: &Vec<u8>) -> Option<encoding::EncodingRef> {
+fn bom_sniffing(bytes: &[u8]) -> Option<encoding::EncodingRef> {
     if bytes.len() < 3 {
         return None;
     }
@@ -27,7 +27,7 @@ fn bom_sniffing(bytes: &Vec<u8>) -> Option<encoding::EncodingRef> {
 /// A lazy implementation of the BOM sniffing algorithm, using `scraper` to parse the HTML and extract the encoding.
 ///
 /// See more details at https://html.spec.whatwg.org/#prescan-a-byte-stream-to-determine-its-encoding
-fn prescan_bytestream(bytes: &Vec<u8>) -> Option<encoding::EncodingRef> {
+fn prescan_bytestream(bytes: &[u8]) -> Option<encoding::EncodingRef> {
     if bytes.len() < 4 {
         return None;
     }