Skip to content

fix: keep content-length header in compressed responses#395

Merged
barjin merged 3 commits intomasterfrom
fix/keep-content-length-header
Mar 2, 2026
Merged

fix: keep content-length header in compressed responses#395
barjin merged 3 commits intomasterfrom
fix/keep-content-length-header

Conversation

@barjin
Copy link
Member

@barjin barjin commented Mar 2, 2026

Closes #388

@barjin barjin requested a review from Copilot March 2, 2026 14:00
@barjin barjin self-assigned this Mar 2, 2026
@github-actions github-actions bot added this to the 135th sprint - Tooling team milestone Mar 2, 2026
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Mar 2, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #388 where Node.js binding responses were missing the content-length header for compressed responses, by updating dependencies and adding a regression test to ensure the header is preserved.

Changes:

  • Add a Node integration test asserting content-length is present alongside content-encoding.
  • Update the Node native binding loader’s expected package version to 0.9.2.
  • Patch Rust dependency resolution to use an Apify fork of tower-http (affecting reqwest’s dependency graph) and update Cargo.lock accordingly.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

File Description
impit-node/test/basics.test.ts Adds a regression test for content-length on compressed responses.
impit-node/index.js Bumps the native binding package version check from 0.9.0 to 0.9.2.
Cargo.toml Patches tower-http to an Apify git source (currently tracking main).
Cargo.lock Locks tower-http to the selected git commit and updates transitive deps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@barjin barjin merged commit c33c7e4 into master Mar 2, 2026
59 of 69 checks passed
@barjin barjin deleted the fix/keep-content-length-header branch March 2, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing content-length header

2 participants