Skip to content

Conversation

ivanvia7
Copy link
Contributor

@ivanvia7 ivanvia7 commented Oct 4, 2025

No description provided.

@ivanvia7 ivanvia7 self-assigned this Oct 4, 2025
@ivanvia7 ivanvia7 requested review from jirispilka and MQ37 October 4, 2025 00:46
Copy link
Contributor

@jirispilka jirispilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just left a couple of minor comments

// EXA_API_KEY is optional; if provided, it's appended as exaApiKey query param.
const { EXA_API_KEY } = process.env;
const EXA_URL_BASE = 'https://mcp.exa.ai/mcp';
const EXA_URL = EXA_API_KEY ? `${EXA_URL_BASE}?exaApiKey=${encodeURIComponent(EXA_API_KEY)}` : EXA_URL_BASE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not going to work without EXA_API_KEY, right? So I would rather fail early than later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it looks like it can work without it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decided to keep it optional as per their docs for now

@ivanvia7
Copy link
Contributor Author

ivanvia7 commented Oct 7, 2025

Thanks for the review, will monitor this one more

@ivanvia7 ivanvia7 merged commit 73f4842 into main Oct 7, 2025
2 checks passed
@ivanvia7 ivanvia7 deleted the feat/exa-mcp-server branch October 7, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants