Skip to content

Conversation

@janbuchar
Copy link
Contributor

@janbuchar janbuchar commented Oct 23, 2025

The action was added to allow bypassing the single-workflow restriction in npm trusted publishing. It simply triggers an external workflow and waits for it to complete. See usage in apify/apify-client-js#770

@janbuchar janbuchar added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 23, 2025
@github-actions github-actions bot added this to the 126th sprint - Tooling team milestone Oct 23, 2025
@janbuchar janbuchar marked this pull request as ready for review October 24, 2025 13:56
@janbuchar janbuchar requested a review from vladfrangu October 29, 2025 21:14
Comment on lines +10 to +11
permissions:
contents: write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed tbh, since you'll be using the service acc token anyways

Copy link
Contributor

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me, thank you!

I guess I'm just not used to committing the whole build artifact to git, so one point about that :)

"description": "Execute GitHub Actions workflows",
"main": "dist/index.js",
"scripts": {
"build": "ncc build src/main.ts -o dist",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing the -m (--minify) flag cuts the size in half. (~1.1MB -> 592kB)

I'm wondering, would this lead to a more compact git history, should the dependencies update from time to time? Or would the minimized file fully rebuild on each update, making larger diffs in the end?

What do you guys think? I suppose we don't care about the readability of the built code, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, let's do that.

@janbuchar
Copy link
Contributor Author

I guess I'm just not used to committing the whole build artifact to git, so one point about that :)

Yeah, trust me I feel that. But we can have at least some type checking of the actions this way, which is nice.

@janbuchar janbuchar merged commit 1751282 into main Oct 30, 2025
3 checks passed
@janbuchar janbuchar deleted the execute-workflow-action branch October 30, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants