-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add execute-workflow action #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed tbh, since you'll be using the service acc token anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me, thank you!
I guess I'm just not used to committing the whole build artifact to git, so one point about that :)
execute-workflow/package.json
Outdated
| "description": "Execute GitHub Actions workflows", | ||
| "main": "dist/index.js", | ||
| "scripts": { | ||
| "build": "ncc build src/main.ts -o dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing the -m (--minify) flag cuts the size in half. (~1.1MB -> 592kB)
I'm wondering, would this lead to a more compact git history, should the dependencies update from time to time? Or would the minimized file fully rebuild on each update, making larger diffs in the end?
What do you guys think? I suppose we don't care about the readability of the built code, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, let's do that.
Co-authored-by: Jindřich Bär <[email protected]>
Co-authored-by: Vlad Frangu <[email protected]>
Yeah, trust me I feel that. But we can have at least some type checking of the actions this way, which is nice. |
The action was added to allow bypassing the single-workflow restriction in npm trusted publishing. It simply triggers an external workflow and waits for it to complete. See usage in apify/apify-client-js#770