This repository was archived by the owner on Aug 4, 2023. It is now read-only.
Open
Conversation
Contributor
Author
|
Are the issues on this one just related to me self-enforcing eslint's comma-dangle rule? If so, can you just chop the offending dangling commas on the merge? I've got to sleep, and this is the third time I've gone through BeyondCompare trying to get things to line up since collapsing commits is the work of the git-devil. |
Member
|
Let's discuss this in #337 first and merge if we decide it's necessary. My initial thoughts are that IoC is not part of the problem domain swagger-tools' middleware should be involved in, especially since swagger-router already provides a means to build your own router mapping. |
that permits instances to be created with custom parameters. This allows use of an IoC container with dynamically wired-up controllers.
Contributor
Author
|
Dangling commas issue fixed, hopefully. Just looking to TravisCI to confirm, but nothing seems to have picked up the need to rebuild yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic IoC Support, including: