This repository was archived by the owner on Aug 4, 2023. It is now read-only.
Issues with logical AND/OR tests#419
Open
thefotios wants to merge 2 commits intoapigee-127:masterfrom
Open
Conversation
7e4e192 to
1e86b1f
Compare
Member
|
Do you mind looking into this @theganyo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know these were old issues (#296, #305) that were explained, but this came up again for me.
The explanations totally make sense, but the tests still do not seem to support them.
I modified what I believe are the test security definitions to match
i'd like to bring this up here with an example just to make sure I'm not crazy before I embark on trying to fix this.
I also noticed that this block might be better written as:
but this would require changing the callbacks and whatnot to not have to short circuit them.
Questions