Remove entity save on config form (#1149)

* Remove entity save on config form

* Removed save() not seeded after set()

* Fixes PHP CS issue - Generic.Strings.UnnecessaryStringConcat.Found

Author: kedarkhaire

src/Form/AuthenticationForm.php

@@ -184,7 +184,7 @@ public function save(array $form, FormStateInterface $form_state) {
     $status = parent::save($form, $form_state);
 
     // Save the authentication key entity id to module's configuration.
-    $this->configFactory->getEditable(static::CONFIG_NAME)->set('active_key', $this->entity->id())->save();
+    $this->configFactory->getEditable(static::CONFIG_NAME)->set('active_key', $this->entity->id());
     // Override the redirect destination.
     $form_state->setRedirect('apigee_edge.settings');
 

tests/src/Kernel/UserAgentTest.php

@@ -81,7 +81,7 @@ public function testUserAgentWithoutMonetization() {
     \Drupal::moduleHandler()->invokeAll('apigee_edge_user_agent_string_alter', [&$user_agent_parts]);
     $userAgentPrefix = implode('; ', $user_agent_parts);
 
-    $this->assertSame($userAgentPrefix, 'Apigee/3.x-dev;' . ' Drupal/' . \Drupal::VERSION);
+    $this->assertSame($userAgentPrefix, 'Apigee/3.x-dev; Drupal/' . \Drupal::VERSION);
   }
 
 }

tests/src/Unit/Command/Util/ApigeeEdgeManagementCliServiceTest.php

@@ -472,7 +472,7 @@ public function testHandleHttpClientExceptions302Code() {
     // User should see error message.
     $io = $this->prophet->prophesize(StyleInterface::class);
     $io->error(Argument::containingString('Error connecting to Apigee Edge'))->shouldBeCalledTimes(1);
-    $io->note(Argument::containingString('the url ' . $this->baseUrl . '/test' . ' does not seem to be a valid Apigee Edge endpoint.'))->shouldBeCalledTimes(1);
+    $io->note(Argument::containingString('the url ' . $this->baseUrl . '/test does not seem to be a valid Apigee Edge endpoint.'))->shouldBeCalledTimes(1);
 
     $apigee_edge_management_cli_service = new ApigeeEdgeManagementCliService($this->httpClient->reveal());
     $apigee_edge_management_cli_service->handleHttpClientExceptions($exception, $io->reveal(), [$this, 'mockDt'], $this->baseUrl . '/test', $this->org, $this->email);