Eliminate repeated update of Drupal users

Author: mxr576

src/Job/DeveloperSync.php

@@ -147,7 +147,7 @@ public function execute(): bool {
       $last_modified_delta = $developer->getLastModifiedAt()->getTimestamp() - $user->getChangedTime();
       // Update Drupal user because the Apigee Edge developer is the most
       // recent.
-      if ($last_modified_delta >= 0) {
+      if ($last_modified_delta > 0) {
         $update_user_job = new UserUpdate($user->getEmail());
         $update_user_job->setTag($this->getTag());
         $this->scheduleJob($update_user_job);

src/Job/UserCreateUpdate.php

@@ -75,6 +75,12 @@ protected function executeRequest() {
         // the same developer in apigee_edge_user_presave() while creating
         // Drupal user based on a developer should be avoided.
         _apigee_edge_set_sync_in_progress(TRUE);
+
+        // Synchronize user's last modified timestamp with developer's timestamp
+        // to maintain data consistency and prevent infinite sync loops where
+        // outdated timestamps cause repeated scheduling of sync operations.
+        // @see \Drupal\apigee_edge\Job\DeveloperSync::execute()
+        $result->getUser()->setChangedTime($developer->getLastModifiedAt()->getTimestamp());
         $result->getUser()->save();
       }
     }
@@ -121,9 +127,6 @@ protected function beforeUserSave(DeveloperToUserConversionResult $result) : voi
         throw $problem;
       }
     }
-    // It's necessary because changed time is automatically updated on the
-    // UI only.
-    $result->getUser()->setChangedTime(\Drupal::time()->getCurrentTime());
   }
 
   /**

src/UserDeveloperConverter.php

@@ -182,6 +182,11 @@ public function convertDeveloper(DeveloperInterface $developer) : DeveloperToUse
       $user = $user_storage->create([
         'pass' => \Drupal::service('password_generator')->generate(),
       ]);
+      // Set user creation date to match the original developer's creation
+      // timestamp to maintain chronological consistency between related
+      // entities and prevent confusion when comparing created vs modified dates
+      // in the user interface.
+      $user->set('created', $developer->getCreatedAt()->getTimestamp());
       // Suppress invalid email validation errors.
       DeveloperEmailUniqueValidator::whitelist($developer->id());
     }