Fix minor cpplint issues.

Author: amarburg

.github/workflows/ci.yaml

@@ -15,20 +15,15 @@ jobs:
       fail-fast: false
       matrix:
         env:
-          - {ROS_DISTRO: noetic}
+          # You need a more modern version of spdlog than provided
+          # by 20.04;  in development could get it from a backports PPA
+          # but can't during CI
+          #- {ROS_DISTRO: noetic}
           - {ROS_DISTRO: jazzy}
           - {ROS_DISTRO: kilted}
           - {ROS_DISTRO: rolling}
 
     steps:
-      - name: Install dependencies with awalsh128/cache-apt-pkgs-action
-        uses: awalsh128/cache-apt-pkgs-action@latest
-        with:
-          packages: libboost-all-dev libspdlog-dev libfmt-dev
-          # Need a more modern version of spdlog than provided by 20.04
-          add-repository: ppa:savoury1/backports
-          version: 1.1
-
       - name: Checkout repository
         uses: actions/checkout@v5
         with:

.github/workflows/ci_cmake.yaml

@@ -17,8 +17,6 @@ jobs:
         uses: awalsh128/cache-apt-pkgs-action@latest
         with:
           packages: libboost-all-dev libspdlog-dev libfmt-dev
-          # Need a more modern version of spdlog than provided by 20.04
-          add-repository: ppa:savoury1/backports
           version: 1.0
 
       - name: Checkout repository

include/liboculus/Logger.h

@@ -35,6 +35,7 @@
 #include <spdlog/common.h>
 #include <spdlog/sinks/stdout_color_sinks.h>
 #include <spdlog/spdlog.h>
+#include <utility>
 
 namespace liboculus {
 
@@ -61,7 +62,7 @@ class Logger {
     Logger::get_logger()->sinks().push_back(s);
   }
 
-  ~Logger() {};
+  ~Logger() {}
 
 private:
   static std::shared_ptr<Logger>
@@ -70,12 +71,13 @@ class Logger {
     return std::shared_ptr<Logger>(new Logger(logger_in));
   }
 
-  Logger(const std::shared_ptr<spdlog::logger> &l = nullptr) : logger_(l) {
+  explicit Logger(const std::shared_ptr<spdlog::logger> &l = nullptr)
+      : logger_(l) {
     if (!logger_) {
       logger_ = std::make_shared<spdlog::logger>("liboculus");
       spdlog::register_logger(logger_);
     }
-  };
+  }
 
   std::shared_ptr<spdlog::logger> logger_;