feat: Load wasm lazily #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Sep 17, 2025
AbhiPrasad
approved these changes
Sep 17, 2025
bizob2828
approved these changes
Sep 19, 2025
Merged
timfish
added a commit
to apm-js-collab/tracing-hooks
that referenced
this pull request
Sep 19, 2025
* Inline wasm binary (apm-js-collab/orchestrion-js#46) * Load wasm lazily (apm-js-collab/orchestrion-js#45)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the auto-generated code has large side-effects which will impact app startup time. We should only be loading the wasm if and when the library is actually used.
This PR adds a wrapper which means the wasm only gets loaded the first time the
createmethod is called.