Skip to content

Conversation

@timfish
Copy link
Member

@timfish timfish commented Sep 10, 2025

No point passing an argument we can derive from the other args!

@timfish timfish requested a review from bizob2828 September 10, 2025 15:37
@timfish timfish changed the title feat: Derive packages from instrumentations feat: Derive packages argument from instrumentations Sep 10, 2025
Copy link
Contributor

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing that, I was meaning to clean this up but haven't gotten around to it

Copy link
Contributor

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update the tests?

@timfish
Copy link
Member Author

timfish commented Sep 10, 2025

Done!

@bizob2828 bizob2828 merged commit 4ea5878 into main Sep 10, 2025
6 checks passed
@jsumners-nr jsumners-nr deleted the feat/dont-require-packages branch September 11, 2025 11:39
@timfish timfish mentioned this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants