Added optional getSize func to Storage.#450
Draft
jimbuck wants to merge 1 commit intoapollographql:masterfrom
Draft
Added optional getSize func to Storage.#450jimbuck wants to merge 1 commit intoapollographql:masterfrom
getSize func to Storage.#450jimbuck wants to merge 1 commit intoapollographql:masterfrom
Conversation
- Allows for storage instances to calculate thier own size. - Fixes `CachePersistor`'s `getSize` function when serialize is `false`.
|
@jimbuck: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
wtrocki
reviewed
May 25, 2022
| return new Promise(resolve => { | ||
| if (this.storage.size === 0) return resolve(0); | ||
| const data = this.storage.get(key); | ||
| resolve((typeof data === 'string' ? data : JSON.stringify(data)).length); |
Collaborator
There was a problem hiding this comment.
Worried about performance implication of serialization just for size limitation.
Typically when using non strings clients data can be very large (like in index db)
I would be reluctant to merge it.
Maybe something like Object.keys(data).length could work?
Collaborator
There was a problem hiding this comment.
I think that would require another sizeFunction argument to be passed by user then default one would simply use string length function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CachePersistor'sgetSizefunction when serialize isfalse.maxSizenot supported when serialize is false #427