Skip to content

Conversation

acemir
Copy link
Contributor

@acemir acemir commented Oct 13, 2025

variableMatcher was removed from Mocklink.MockedResponse on Apollo Client 4.0

@apollo-cla
Copy link

@acemir: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2025

⚠️ No Changeset found

Latest commit: f6f9ee5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@acemir acemir changed the title Add deprecation notice to variableMatcher chore: add deprecation notice to variableMatcher Oct 13, 2025
@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from 9662d8e to 1e02553 Compare October 13, 2025 09:13
@jerelmiller
Copy link
Member

Hey @acemir 👋

Appreciate the PR! We'll need to do a bit of work to allow the version-3.x branch to be releasable (we originally planned for 3.14.0 to be the last 3.x change). This change looks ok otherwise! Please be patient with us for a little bit until we can get that in place.

@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from 1e02553 to cc1e467 Compare October 21, 2025 22:33
@acemir acemir requested a review from a team as a code owner October 21, 2025 22:33
@acemir acemir closed this Oct 21, 2025
@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from cc1e467 to cdcd7ed Compare October 21, 2025 22:45
@acemir acemir reopened this Oct 21, 2025
@acemir acemir changed the title chore: add deprecation notice to variableMatcher chore: add @deprecated notice to variableMatcher Oct 22, 2025
@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from 368b50a to 8a730a0 Compare October 22, 2025 02:20
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 22, 2025

npm i https://pkg.pr.new/@apollo/client@12970

commit: f6f9ee5

`variableMatcher` was removed from `Mocklink.MockedResponse` on Apollo 4.0
@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from 8a730a0 to f6f9ee5 Compare October 22, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants