-
Notifications
You must be signed in to change notification settings - Fork 71
fix: SelectionSet
equality in 1.x
#771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calvincestari
wants to merge
13
commits into
v1
Choose a base branch
from
fix/v1-equality-check
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,413
−16
Open
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2ea0796
Refactor SelectionSet equality to recover type data
calvincestari bfeb4c4
Adds equality tests
calvincestari 8a53f79
Adds another test for type cast edge case
calvincestari d417bee
Fix incorrect DataDict test key names
calvincestari 57526e6
Refactor type casting
calvincestari 469ef00
Fix for nullable objects being null in equality checks
calvincestari 7ae6874
Add integration test
calvincestari f28dff6
Refactor scalar casting logic for nullable object types
calvincestari cc8a2de
Refactor scalar casting logic for lists
calvincestari df986c5
Fix and add tests
calvincestari 893a4f5
Remove test mock infrastructure hash and equality implementations
calvincestari 62f5c2b
Additional test using pagination problem model
calvincestari ab8f785
Refactor equality logic
calvincestari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SelectionSet
now has it's own equality implementation.