Skip to content

Commit c10f02a

Browse files
martinbonninmartinbonnin
authored
Better KDoc escape (#5155)
* Better KDoc escape * update test fixtures
1 parent 7996ab1 commit c10f02a

File tree

156 files changed

+478
-147
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

156 files changed

+478
-147
lines changed

‎libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/codegen/kotlin/file/OperationBuilder.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,12 @@ internal class OperationBuilder(
204204

205205

206206
/**
207-
* Things like `[${'$'}oo]` do not compile. See https://youtrack.jetbrains.com/issue/KT-43906
207+
* Things like `[${'$'}oo]` do not compile.
208+
*
209+
* See https://youtrack.jetbrains.com/issue/KT-43906
208210
*/
209211
private fun String.escapeKdoc(): String {
210-
return replace("[", "\\[").replace("]", "\\]")
212+
return "```\n$this\n```\n"
211213
}
212214

213215
private fun rootFieldFunSpec(): FunSpec {

‎libraries/apollo-compiler/src/test/graphql/com/example/antlr_tokens/kotlin/responseBased/antlr_tokens/TestQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/arguments_hardcoded/kotlin/responseBased/arguments_hardcoded/TestQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/big_query/kotlin/responseBased/big_query/TestQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/capitalized_fields/kotlin/operationBased/capitalized_fields/TestQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/capitalized_fields/kotlin/responseBased/capitalized_fields/TestQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/case_sensitive_enum/kotlin/responseBased/case_sensitive_enum/TestQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/companion/kotlin/operationBased/companion/TestQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/custom_scalar_type/kotlin/responseBased/custom_scalar_type/TestQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎libraries/apollo-compiler/src/test/graphql/com/example/data_builders/kotlin/operationBased/data_builders/AnimalQuery.kt.expected

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)