Add support for directives on directive definitions #6803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: eb153bff2f4b7743a02e13b7 |
BoD
force-pushed
the
directives-on-directives
branch
from
4136952 to
55cbd1e
Compare
Contributor
Author
|
Related graphql-js PR: graphql/graphql-js#4521 |
martinbonnin
requested changes
Jan 6, 2026
Contributor
martinbonnin
left a comment
martinbonnin
left a comment
There was a problem hiding this comment.
LGTM except this should be opt-in until this is in the spec.
Also do you mind updating the execution part of it? (here) Or I can do it later if you prefer.
libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo/ast/gql.kt
Show resolved
Hide resolved
libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo/ast/internal/Parser.kt
Outdated
Show resolved
Hide resolved
libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo/ast/gql.kt
Show resolved
Hide resolved
BoD
force-pushed
the
directives-on-directives
branch
from
846da91 to
db06df6
Compare
martinbonnin
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on this draft spec change.