Skip to content

Fix validation of @oneOf input objects. #6894

Merged
martinbonnin merged 1 commit intomainfrom
oneof-inhabitability
Mar 16, 2026
Merged

Fix validation of @oneOf input objects. #6894
martinbonnin merged 1 commit intomainfrom
oneof-inhabitability

Conversation

@martinbonnin
Copy link
Contributor

They may be invalid if they create cycles

See graphql/graphql-spec#1211

@martinbonnin martinbonnin requested a review from BoD as a code owner March 16, 2026 13:18
@apollo-librarian
Copy link

apollo-librarian bot commented Mar 16, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: f466f85841d3d9920708fa4e
Build Logs: View logs


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return path
}

internal fun tarjanScc(nodes: Collection<Node>): Collection<Scc> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same!

@martinbonnin martinbonnin merged commit 2c072e0 into main Mar 16, 2026
10 of 11 checks passed
@martinbonnin martinbonnin deleted the oneof-inhabitability branch March 16, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants