Skip to content

Conversation

@andrewmcgivery
Copy link
Collaborator

The app name being prefixed to the tool name is a holdover from prior to having the app=xxx query param. It was to prevent 2 apps with the same tool name from colliding. This is no longer required since we only serve the tools for 1 app given the app query param.

The app name being prefixed to the tool name is a holdover from prior to having the app=xxx query param. It was to prevent 2 apps with the same tool name from colliding. This is no longer required since we only serve the tools for 1 app given the app query param.
@andrewmcgivery andrewmcgivery requested a review from a team as a code owner January 30, 2026 23:11
@apollo-librarian
Copy link

apollo-librarian bot commented Jan 30, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: b0a7d9abf58bcef75b1fab43
Build Logs: View logs

@github-actions
Copy link

github-actions bot commented Jan 30, 2026

⏭️ Changeset check skipped via label

@andrewmcgivery andrewmcgivery added the skip-changeset Used when the changeset verification can be skipped label Jan 30, 2026
@claude
Copy link

claude bot commented Jan 30, 2026

Review Summary

This PR removes the app name prefix from tool names, simplifying the naming scheme now that tools are isolated per app via the app=xxx query parameter. The change is clean and well-motivated.

Findings:

  • No blocking, should-fix, or consider-level issues identified
  • Test coverage is appropriate - existing unit tests updated to reflect new behavior
  • Code is simple, focused, and backwards-compatible

Test Coverage Assessment:
The existing test suite properly validates the change:

  • multiple_tools_in_an_app test updated to verify unprefixed tool names
  • All three tool name assertions updated consistently
  • Test coverage remains comprehensive for the manifest loading logic

Recommendation: Approve


Reviewed by Claude Code Sonnet 4.5

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@andrewmcgivery andrewmcgivery merged commit b8a75e9 into main Jan 30, 2026
15 of 16 checks passed
@andrewmcgivery andrewmcgivery deleted the am/apps-strip-app-name-from-tool branch January 30, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changeset Used when the changeset verification can be skipped

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants