When calculating app target, attempt to autodetect from advertised capabilities if not specified in url#649
Conversation
…pabilities if not specified in url
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 634494c18d5ef97d1cdef995 |
|
⏭️ Changeset check skipped via label |
| version: self.server_info.version().to_string(), | ||
| website_url: self.server_info.website_url().map(|s| s.to_string()), | ||
| // TODO: Add support for this via configuration similar to above fields | ||
| description: None, |
There was a problem hiding this comment.
Just noting here that I will be creating a Jira task for this for a follow up PR.
Review SummaryThis PR adds MCP app capability auto-detection when the app target is not explicitly specified in the URL. The implementation updates from rmcp 0.14 to 0.16 and introduces a new capability detection mechanism. The changes are well-structured with good test coverage for the new behavior. FindingsCode Quality (Minor)
Test Coverage Assessment✅ Excellent test coverage - The PR includes comprehensive tests for:
Final RecommendationApprove with suggestions - The implementation is solid and well-tested. The minor suggestions around test organization and allocations are optional improvements that don't impact correctness. Reviewed by Claude Code Sonnet 4.5 |
DaleSeo
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the upgrade!
When calculating app target, attempt to autodetect from advertised capabilities if not specified in url.
Note this PR also updated rmcp to latest (0.14 -> 0.16)
Changelogs: