Skip to content

Launch non-feature flagged support for MCP Apps and OpenAI AppsSDK#652

Merged
andrewmcgivery merged 3 commits intomainfrom
am/release-apps
Feb 26, 2026
Merged

Launch non-feature flagged support for MCP Apps and OpenAI AppsSDK#652
andrewmcgivery merged 3 commits intomainfrom
am/release-apps

Conversation

@andrewmcgivery
Copy link
Contributor

No description provided.

@apollo-librarian
Copy link

apollo-librarian bot commented Feb 18, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 2 changed, 0 removed
* (developer-tools)/apollo-mcp-server/(latest)/config-file.mdx
* (developer-tools)/apollo-mcp-server/(latest)/define-tools.mdx

Build ID: a0b566b0df3dfe58a0391746
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/a0b566b0df3dfe58a0391746


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

Corrected grammatical errors in the documentation.
@andrewmcgivery andrewmcgivery marked this pull request as ready for review February 26, 2026 01:49
@andrewmcgivery andrewmcgivery requested a review from a team as a code owner February 26, 2026 01:49
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

Changeset file added - thank you!

@claude
Copy link

claude bot commented Feb 26, 2026

Review Summary

This PR cleanly removes the apps feature flag, making MCP Apps and OpenAI AppsSDK support always available. The code changes are well-structured and maintain proper error handling.

Findings

  • [Should Fix] Markdown link syntax errors in changeset file - links should use [text](url) format, not (text)[url]

Test Coverage Assessment

The apps modules have existing unit tests, which should provide adequate coverage now that this functionality is always enabled.

Final Recommendation

Approve with suggestions - Fix the markdown syntax in the changeset file.


Reviewed by Claude Code Sonnet 4.5

@claude
Copy link

claude bot commented Feb 26, 2026

Review Summary

This PR cleanly removes the apps feature flag, making MCP Apps and OpenAI AppsSDK support always available. The changes are minimal, well-structured, and maintain proper error handling. The previous markdown formatting issues identified in an earlier review have been addressed in subsequent commits.

Findings

No issues found. The code changes are correct and follow Rust best practices:

  • Error handling is properly maintained with map_err(ServerError::Apps)?
  • The changeset documentation is accurate and well-formatted
  • Existing test coverage in the apps module is adequate

Test Coverage Assessment

The apps modules contain existing unit tests which provide appropriate coverage for this functionality now that it's always enabled.

Final Recommendation

Approve - This is a clean, focused change that simplifies the codebase by removing conditional compilation while maintaining all existing functionality and error handling.


Reviewed by Claude Code Sonnet 4.5

@andrewmcgivery andrewmcgivery merged commit 2c9ffc8 into main Feb 26, 2026
13 checks passed
@andrewmcgivery andrewmcgivery deleted the am/release-apps branch February 26, 2026 01:56
@DaleSeo DaleSeo mentioned this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants