Skip to content

Set _meta['openai/widgetPrefersBorder']#668

Merged
jerelmiller merged 4 commits intomainfrom
jerel/prefers-border
Feb 27, 2026
Merged

Set _meta['openai/widgetPrefersBorder']#668
jerelmiller merged 4 commits intomainfrom
jerel/prefers-border

Conversation

@jerelmiller
Copy link
Member

At the moment it seems like ChatGPT ignores _meta.ui.prefersBorder but honors _meta['openai/widgetPrefersBorder'] so this PR makes sure its set when rendering an OpenAI app.

@jerelmiller jerelmiller requested a review from a team as a code owner February 27, 2026 02:05
@apollo-librarian
Copy link

apollo-librarian bot commented Feb 27, 2026

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 6b87516b491733b5d473a061
Build Logs: View logs


✅ AI Style Review — No Changes Detected

No MDX files were changed in this pull request.

Review Log: View detailed log

This review is AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Changeset file added - thank you!

@claude
Copy link

claude bot commented Feb 27, 2026

Review Summary

This PR adds openai/widgetPrefersBorder metadata as a workaround for ChatGPT ignoring the standard _meta.ui.prefersBorder field. The implementation is clean, follows existing patterns in the codebase (similar to the CSP workaround), and includes comprehensive test coverage.

Update: The author has addressed all previous feedback by adding an explanatory comment (lines 134-135) that documents why this OpenAI-specific field is needed.

Code Quality: ✅ Excellent

  • Security: No issues - proper use of unwrap_or_default(), no unsafe blocks
  • Performance: No concerns - no unnecessary allocations or clones
  • Correctness: Follows existing architectural patterns, idiomatic Rust code
  • Error Handling: Appropriate and consistent with codebase standards

Test Coverage: ✅ Comprehensive

  • Line 258: Positive case verifies AppsSDK target includes openai/widgetPrefersBorder
  • Line 328: Negative case verifies MCPApps target does not include it
  • Both scenarios properly validated

Documentation: ✅ Clear

  • Lines 134-135: Explanatory comment documents the ChatGPT compatibility issue
  • Comment clearly explains this is a temporary workaround

Final Recommendation: ✅ Approve

The code is correct, well-tested, properly documented, and follows Rust best practices. All previous feedback has been addressed. Ready to merge.


Reviewed by Claude Code Sonnet 4.5

Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a missing closing quote

Co-authored-by: Dale Seo <5466341+DaleSeo@users.noreply.github.com>
@jerelmiller jerelmiller merged commit 8b331d5 into main Feb 27, 2026
16 checks passed
@jerelmiller jerelmiller deleted the jerel/prefers-border branch February 27, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants