-
Couldn't load subscription status.
- Fork 46
[email protected] #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+45
−14
Merged
[email protected] #968
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,25 +17,56 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |
| ## Maintenance | ||
| ## Documentation--> | ||
|
|
||
| # [1.2x.x] (unreleased) - 2025-mm-dd | ||
| # [1.28.0](https://crates.io/crates/apollo-compiler/1.28.0) - 2025-04-23 | ||
|
|
||
| ## Features | ||
|
|
||
| - **Reject `@skip`/`@include` on subscription root fields - [DerekKuc] [SimonSapin] and [goto-bus-stop], [pull/963]** | ||
|
|
||
| This implements a [GraphQL spec RFC](https://github.com/graphql/graphql-spec/pull/860), rejecting | ||
| subscriptions in validation that can be invalid during execution. | ||
|
|
||
| - **New shorthand methods for mutable directive argument access - [tninesling], [pull/967]** | ||
|
|
||
| Introduces new methods: | ||
| - `DirectiveList::get_all_mut` | ||
| - `DirectiveList::argument_by_name_mut` | ||
| - `DirectiveList::specified_argument_by_name_mut` | ||
|
|
||
| ## Fixes | ||
|
|
||
| - **Update `ariadne` trait implementations - [lrlna], [pull/960]** | ||
| `[email protected]` release changed their type signature for `ariadne::Cache` trait, which required an update to `apollo-compiler`'s implementation of `ariadne::Cache<FileId>`. | ||
|
|
||
| This release also had a slight change to path formatting, so if you had any snapshots in your tests, you can expect a change from this: | ||
| ``` | ||
| Error: `typeFragment1` contains too much nesting | ||
| ╭─[overflow.graphql:11:11] | ||
| ``` | ||
| `[email protected]` release changed their type signature for `ariadne::Cache` trait, which required an | ||
| update to `apollo-compiler`'s implementation of `ariadne::Cache<FileId>`. | ||
|
|
||
| to this (notice the extra white space around the file path): | ||
| ``` | ||
| Error: `typeFragment1` contains too much nesting | ||
| ╭─[ overflow.graphql:11:11 ] | ||
| ``` | ||
| This release also had a slight change to path formatting, so if you had any snapshots in your | ||
| tests, you can expect a change from this: | ||
| ``` | ||
| Error: `typeFragment1` contains too much nesting | ||
| ╭─[overflow.graphql:11:11] | ||
| ``` | ||
|
|
||
| to this (notice the extra white space around the file path): | ||
| ``` | ||
| Error: `typeFragment1` contains too much nesting | ||
| ╭─[ overflow.graphql:11:11 ] | ||
| ``` | ||
|
|
||
| - **Harden stack overflow protection - [goto-bus-stop], [pull/966]** | ||
|
|
||
| Closes a theoretical gap in stack overflow protection when processing long fragment chains, and | ||
| significantly improves validation performance on documents with thousands of fragment definitions. | ||
|
|
||
| [lrlna]: https://github.com/lrlna | ||
| [DerekKuc]: https://github.com/DerekKuc | ||
goto-bus-stop marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| [goto-bus-stop]: https://github.com/goto-bus-stop | ||
| [SimonSapin]: https://github.com/SimonSapin | ||
| [tninesling]: https://github.com/tninesling | ||
| [pull/960]: https://github.com/apollographql/apollo-rs/pull/960 | ||
| [pull/963]: https://github.com/apollographql/apollo-rs/pull/963 | ||
| [pull/966]: https://github.com/apollographql/apollo-rs/pull/966 | ||
| [pull/967]: https://github.com/apollographql/apollo-rs/pull/967 | ||
|
|
||
| # [1.27.0](https://crates.io/crates/apollo-compiler/1.26.0) - 2025-03-04 | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| [package] | ||
| name = "apollo-compiler" | ||
| version = "1.27.0" # When bumping, also update README.md | ||
| version = "1.28.0" # When bumping, also update README.md | ||
| authors = ["Irina Shestak <[email protected]>"] | ||
| license = "MIT OR Apache-2.0" | ||
| repository = "https://github.com/apollographql/apollo-rs" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.