Skip to content

Conversation

@phryneas
Copy link
Member

This came up in #8167

@phryneas phryneas requested review from a team and glasser as code owners December 17, 2025 13:23
@apollo-librarian
Copy link

apollo-librarian bot commented Dec 17, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* (developer-tools)/apollo-server/(latest)/api/plugin/subscription-callback.mdx

Build ID: 853829c52f5915483b0c6479
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/853829c52f5915483b0c6479

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@phryneas phryneas enabled auto-merge December 17, 2025 13:56
@mario-jerkovic
Copy link

@phryneas cc: @bnjjj shouldn't this removed property from the ApolloServerPluginSubscriptionCallback docs be replace with maxConsecutiveHeartbeatFailures, this one isn't documented at all.

@phryneas
Copy link
Member Author

phryneas commented Dec 17, 2025

@mario-jerkovic I have to admit, I'm not very familiar with the history here, but looking at #7793, it seems this was removed independently and maxConsecutiveHeartbeatFailures wasn't added as an immediate alternative/workaround.

I do agree that maxConsecutiveHeartbeatFailures should probably be documented, but someone else with more domain knowledge would have to do that. I'm just trying to at least get incorrect information out of the docs with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants